Skip to content

feat!: wasm-dpp-integration#984

Merged
markin-io merged 8 commits into
v0.25-devfrom
feat/wasm-dpp-integration
Apr 28, 2023
Merged

feat!: wasm-dpp-integration#984
markin-io merged 8 commits into
v0.25-devfrom
feat/wasm-dpp-integration

Conversation

@markin-io

@markin-io markin-io commented Apr 26, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Backport of #848

What was done?

  • Backported feat!: wasm-dpp integration #848
  • Fixed bug with json! wrapper in where query for indices validation
  • Added StateTransitionExecutionContext to validateBasic calls in SDK
  • Removed js-drive and rs-drive-nodejs workflows from pull request CI

How Has This Been Tested?

  • Ensured that network starts in Run platform test suite workflow
  • Ensured that wasm-dpp is building properly for SDK, DAPI, Wallet-lib

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io
markin-io force-pushed the feat/wasm-dpp-integration branch from ea3c723 to 8a47249 Compare April 27, 2023 14:46
@markin-io
markin-io force-pushed the feat/wasm-dpp-integration branch from 8a47249 to 2fd674e Compare April 27, 2023 18:11
@markin-io markin-io changed the title feat: wasm-dpp-integration feat!: wasm-dpp-integration Apr 27, 2023
@markin-io
markin-io marked this pull request as ready for review April 27, 2023 18:23
@strophy

strophy commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator

What backend is sccache using here, does it depend on the GitHub Actions cache? Did you test this works on AWS self-hosted runners?

shumkov
shumkov requested changes Apr 28, 2023
View reviewed changes
Comment thread .github/workflows/all-packages.yml
@markin-io
markin-io changed the base branch from v0.25-dev to v0.24-dev April 28, 2023 09:35
@markin-io
markin-io changed the base branch from v0.24-dev to v0.25-dev April 28, 2023 09:37
@markin-io

markin-io commented Apr 28, 2023

Copy link
Copy Markdown
Contributor Author

@strophy the change was cherry picked as is from v0.24.
No other CI related manipulations were made

shumkov
shumkov approved these changes Apr 28, 2023
View reviewed changes

@shumkov shumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markin-io
markin-io merged commit fcd8c17 into v0.25-dev Apr 28, 2023
@markin-io
markin-io deleted the feat/wasm-dpp-integration branch April 28, 2023 09:44
@thephez thephez added this to the v0.25.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumkov shumkov shumkov approved these changes
@antouhou antouhou Awaiting requested review from antouhou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@markin-io @strophy @shumkov @thephez