Skip to content

fix(dashmate)!: multiple issues in the reset command#991

Merged
shumkov merged 4 commits into
v0.24-devfrom
fix/dashmate/soft_reset_and_force_flag
Apr 28, 2023
Merged

fix(dashmate)!: multiple issues in the reset command#991
shumkov merged 4 commits into
v0.24-devfrom
fix/dashmate/soft_reset_and_force_flag

Conversation

@shumkov

@shumkov shumkov commented Apr 28, 2023

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

The reset and group reset commands do not work with --force flag

What was done?

  • Remove containers and volumes in two steps since docker compose rm --stop --volumes doesn't work properly.
  • Fixed group soft reset
  • Refactored reset logic
  • Renamed the --platfrom-only to --platform flag follow naming convention with other commands

How Has This Been Tested?

Manually

Breaking Changes

  • The --platfrom-only flag is renamed to --platform

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov
shumkov requested a review from antouhou as a code owner April 28, 2023 06:42
@shumkov shumkov changed the title fix(dashmate): force reset fails with volume deletion fix(dashmate): multiple issues in the reset command Apr 28, 2023
@shuplenkov shuplenkov changed the title fix(dashmate): multiple issues in the reset command fix(dashmate)!: multiple issues in the reset command Apr 28, 2023
@shumkov
shumkov merged commit 0e263be into v0.24-dev Apr 28, 2023
@shumkov
shumkov deleted the fix/dashmate/soft_reset_and_force_flag branch April 28, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants