Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

feat: withdrawal status sync process#175

Open
jawid-h wants to merge 24 commits into
v0.24-devfrom
feat/withdrawal-document
Open

feat: withdrawal status sync process#175
jawid-h wants to merge 24 commits into
v0.24-devfrom
feat/withdrawal-document

Conversation

@jawid-h

@jawid-h jawid-h commented Nov 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

As per document this PR implements Withdrawal Document creation and sync process

What was done?

  • updated ABCI handlers
  • updated apply process of the IdentityCreditWithdrawalStateTransition

How Has This Been Tested?

  • unit testing

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

shumkov
shumkov suggested changes Nov 17, 2022
View reviewed changes
Comment thread dash-abci/src/abci/handlers.rs Outdated
Comment thread ...identity_credit_withdrawal_transition/apply_identity_credit_withdrawal_transition_factory.rs Outdated
Comment thread ...identity_credit_withdrawal_transition/apply_identity_credit_withdrawal_transition_factory.rs Outdated
Comment thread ...identity_credit_withdrawal_transition/apply_identity_credit_withdrawal_transition_factory.rs Outdated
Comment thread ...thdrawal_transition/validation/state/validate_identity_credit_withdrawal_transition_state.rs Outdated
Comment thread ...dit_withdrawal_transition/validation/state/validate_identity_credit_withdrawal_state_spec.rs Outdated
Comment thread drive/src/drive/identity/withdrawal_queue.rs Outdated
Comment thread drive/src/drive/identity/withdrawal_queue.rs Outdated
@jawid-h
jawid-h marked this pull request as ready for review November 28, 2022 15:37
@jawid-h jawid-h changed the title Feat/withdrawal document feat: withdrawal status sync process Nov 28, 2022
@jawid-h
jawid-h requested a review from shumkov November 28, 2022 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shumkov shumkov Awaiting requested review from shumkov

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jawid-h @shumkov