feat: special transactions#5
Conversation
…shcore into feat/specialTransactions
| /// A Dash devnet | ||
| Devnet <-> "devnet", | ||
| /// Dash's regtest | ||
| Regtest <-> "regtest" |
There was a problem hiding this comment.
What means this syntax, can't find anything similar https://doc.rust-lang.org/reference/items/enumerations.html
There was a problem hiding this comment.
Hm, that's an interesting thing indeed. Probably some deprecated syntax? This code was originally written for the very first version of the compiler
There was a problem hiding this comment.
I think this syntax is not part of the language but has been introduced by wrapping macro user_enum!
| use hashes::sha256d; | ||
| use blockdata::opcodes; | ||
| use blockdata::script; | ||
| use blockdata::transaction::{OutPoint, Transaction, TxOut, TxIn}; |
There was a problem hiding this comment.
What was the problem with use blockdata::transaction::{OutPoint, Transaction, TxOut, TxIn};?
There was a problem hiding this comment.
They got moved to their own files.
| assert_eq!(out_point.vout, 0); | ||
| assert_eq!(out_point.txid, tx.txid()); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Please don't forget about the newlines
| use blockdata::block::Block; | ||
| use blockdata::script::Script; | ||
| use blockdata::transaction::OutPoint; | ||
| use blockdata::transaction::outpoint::OutPoint; |
There was a problem hiding this comment.
What do you thing about re-exporting the OutPoint, so the lib external interface stays the same? I.e. pub use outpoint::OutPoint
| } | ||
|
|
||
| #[cfg(test)] | ||
| #[cfg(feature="signer")] |
There was a problem hiding this comment.
Yes, because the test requires signing.
5 participants
No description provided.