Skip to content

refactor(key-wallet): make WatchOnly / ExternalSignable unit variants#654

Merged
xdustinface merged 2 commits into
v0.42-devfrom
feat/wallet-type-unit-variants
Apr 17, 2026
Merged

refactor(key-wallet): make WatchOnly / ExternalSignable unit variants#654
xdustinface merged 2 commits into
v0.42-devfrom
feat/wallet-type-unit-variants

docs(key-wallet): correct derive_*_public_key docstrings for unit var…

8a91617
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 17, 2026 in 1s

68.02% (+0.03%) compared to 7e2aa23

View this Pull Request on Codecov

68.02% (+0.03%) compared to 7e2aa23

Details

Codecov Report

❌ Patch coverage is 84.21053% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.02%. Comparing base (7e2aa23) to head (8a91617).

Files with missing lines Patch % Lines
key-wallet/src/wallet/initialization.rs 86.48% 5 Missing ⚠️
key-wallet/src/wallet/root_extended_keys.rs 81.81% 4 Missing ⚠️
...src/wallet/managed_wallet_info/managed_accounts.rs 0.00% 3 Missing ⚠️
key-wallet/src/wallet/mod.rs 86.66% 2 Missing ⚠️
key-wallet/src/wallet/helper.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #654      +/-   ##
=============================================
+ Coverage      67.99%   68.02%   +0.03%     
=============================================
  Files            319      319              
  Lines          67970    67994      +24     
=============================================
+ Hits           46216    46255      +39     
+ Misses         21754    21739      -15     
Files with missing lines Coverage Δ
key-wallet-manager/src/lib.rs 61.18% <100.00%> (-0.53%) ⬇️
key-wallet/src/wallet/helper.rs 50.31% <92.30%> (+8.47%) ⬆️
key-wallet/src/wallet/mod.rs 87.82% <86.66%> (+0.76%) ⬆️
...src/wallet/managed_wallet_info/managed_accounts.rs 19.85% <0.00%> (+0.21%) ⬆️
key-wallet/src/wallet/root_extended_keys.rs 52.89% <81.81%> (+1.51%) ⬆️
key-wallet/src/wallet/initialization.rs 91.44% <86.48%> (-1.47%) ⬇️

... and 17 files with indirect coverage changes