Skip to content

refactor(key-wallet): split ManagedCoreAccount into funds + keys variants#711

Merged
xdustinface merged 4 commits into
v0.42-devfrom
claude/adoring-booth-151626
May 5, 2026
Merged

refactor(key-wallet): split ManagedCoreAccount into funds + keys variants#711
xdustinface merged 4 commits into
v0.42-devfrom
claude/adoring-booth-151626

refactor(key-wallet): dedupe core account types via shared trait + co…

10cb2b9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 5, 2026 in 1s

71.14% (+0.05%) compared to 2cf45b8

View this Pull Request on Codecov

71.14% (+0.05%) compared to 2cf45b8

Details

Codecov Report

❌ Patch coverage is 61.90476% with 328 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.14%. Comparing base (2cf45b8) to head (10cb2b9).

Files with missing lines Patch % Lines
...allet/src/managed_account/managed_account_trait.rs 38.17% 149 Missing ⚠️
.../src/managed_account/managed_core_funds_account.rs 75.78% 92 Missing ⚠️
...t/src/managed_account/managed_core_keys_account.rs 55.12% 35 Missing ⚠️
...y-wallet/src/wallet/managed_wallet_info/helpers.rs 57.14% 18 Missing ⚠️
key-wallet-ffi/src/address_pool.rs 0.00% 11 Missing ⚠️
key-wallet-ffi/src/managed_account.rs 40.00% 9 Missing ⚠️
.../src/managed_account/managed_account_collection.rs 72.22% 5 Missing ⚠️
...src/wallet/managed_wallet_info/managed_accounts.rs 16.66% 5 Missing ⚠️
...wallet/src/transaction_checking/account_checker.rs 83.33% 2 Missing ⚠️
key-wallet-ffi/src/managed_wallet.rs 66.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@              Coverage Diff              @@
##           v0.42-dev     #711      +/-   ##
=============================================
+ Coverage      71.09%   71.14%   +0.05%     
=============================================
  Files            319      320       +1     
  Lines          68574    68610      +36     
=============================================
+ Hits           48751    48816      +65     
+ Misses         19823    19794      -29
Files with missing lines Coverage Δ
dash-spv/src/sync/mempool/sync_manager.rs 98.72% <ø> (ø)
key-wallet-manager/src/lib.rs 62.10% <ø> (ø)
key-wallet/src/account/mod.rs 62.79% <ø> (ø)
...et/src/managed_account/managed_platform_account.rs 64.28% <ø> (ø)
...-wallet/src/transaction_checking/wallet_checker.rs 99.38% <100.00%> (ø)
...c/wallet/managed_wallet_info/asset_lock_builder.rs 79.61% <100.00%> (ø)
...allet/managed_wallet_info/wallet_info_interface.rs 83.22% <100.00%> (ø)
key-wallet-ffi/src/managed_wallet.rs 81.34% <66.66%> (+10.19%) ⬆️
key-wallet-ffi/src/transaction.rs 0.00% <0.00%> (ø)
...wallet/src/transaction_checking/account_checker.rs 67.02% <83.33%> (ø)
... and 8 more

... and 4 files with indirect coverage changes

View more details on Codecov