Skip to content

refactor: move core tx building and signing logic into the key-wallet and key-wallet-manager crates#727

Merged
xdustinface merged 1 commit into
v0.42-devfrom
refactor/tx-building
May 6, 2026
Merged

refactor: move core tx building and signing logic into the key-wallet and key-wallet-manager crates#727
xdustinface merged 1 commit into
v0.42-devfrom
refactor/tx-building

move core tx building and signing into the key-wallet-manager crate

1fe408d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 6, 2026 in 1s

71.32% (+0.09%) compared to d4b22bf

View this Pull Request on Codecov

71.32% (+0.09%) compared to d4b22bf

Details

Codecov Report

❌ Patch coverage is 34.37500% with 105 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.32%. Comparing base (d4b22bf) to head (1fe408d).

Files with missing lines Patch % Lines
...wallet/managed_wallet_info/transaction_building.rs 0.00% 55 Missing ⚠️
key-wallet/src/wallet/managed_wallet_info/mod.rs 68.96% 18 Missing ⚠️
key-wallet-ffi/src/transaction.rs 0.00% 16 Missing ⚠️
key-wallet-manager/src/lib.rs 40.90% 13 Missing ⚠️
key-wallet-manager/src/error.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #727      +/-   ##
=============================================
+ Coverage      71.22%   71.32%   +0.09%     
=============================================
  Files            320      320              
  Lines          68788    68710      -78     
=============================================
+ Hits           48996    49006      +10     
+ Misses         19792    19704      -88     
Files with missing lines Coverage Δ
key-wallet-manager/src/process_block.rs 92.56% <100.00%> (ø)
key-wallet-manager/src/error.rs 0.00% <0.00%> (ø)
key-wallet-manager/src/lib.rs 75.25% <40.90%> (+12.89%) ⬆️
key-wallet-ffi/src/transaction.rs 0.00% <0.00%> (ø)
key-wallet/src/wallet/managed_wallet_info/mod.rs 68.69% <68.96%> (+0.27%) ⬆️
...wallet/managed_wallet_info/transaction_building.rs 71.64% <0.00%> (-26.99%) ⬇️

... and 5 files with indirect coverage changes