Skip to content

refactor(key-wallet): dedupe core account types via shared trait + composition#728

Merged
xdustinface merged 3 commits into
claude/adoring-booth-151626from
claude/managed-account-dedupe
May 5, 2026
Merged

refactor(key-wallet): dedupe core account types via shared trait + composition#728
xdustinface merged 3 commits into
claude/adoring-booth-151626from
claude/managed-account-dedupe

fix(key-wallet): satisfy CI rustfmt + drop rustdoc link to private item

3335954
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 5, 2026 in 0s

70.94% (+0.65%) compared to 425bc19

View this Pull Request on Codecov

70.94% (+0.65%) compared to 425bc19

Details

Codecov Report

❌ Patch coverage is 52.91139% with 186 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.94%. Comparing base (425bc19) to head (3335954).

Files with missing lines Patch % Lines
...allet/src/managed_account/managed_account_trait.rs 38.17% 149 Missing ⚠️
.../src/managed_account/managed_core_funds_account.rs 76.59% 11 Missing ⚠️
key-wallet-ffi/src/address_pool.rs 0.00% 9 Missing ⚠️
key-wallet-ffi/src/managed_account.rs 30.76% 9 Missing ⚠️
.../src/managed_account/managed_account_collection.rs 33.33% 2 Missing ⚠️
...t/src/managed_account/managed_core_keys_account.rs 86.66% 2 Missing ⚠️
...wallet/src/transaction_checking/account_checker.rs 81.81% 2 Missing ⚠️
key-wallet-ffi/src/managed_wallet.rs 50.00% 1 Missing ⚠️
key-wallet-ffi/src/transaction.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           claude/adoring-booth-151626     #728      +/-   ##
===============================================================
+ Coverage                        70.28%   70.94%   +0.65%     
===============================================================
  Files                              320      320              
  Lines                            68527    68247     -280     
===============================================================
+ Hits                             48167    48417     +250     
+ Misses                           20360    19830     -530     
Files with missing lines Coverage Δ
key-wallet-manager/src/lib.rs 62.83% <ø> (ø)
...-wallet/src/transaction_checking/wallet_checker.rs 99.39% <100.00%> (ø)
...c/wallet/managed_wallet_info/asset_lock_builder.rs 79.61% <100.00%> (ø)
...src/wallet/managed_wallet_info/managed_accounts.rs 19.85% <ø> (ø)
...allet/managed_wallet_info/wallet_info_interface.rs 81.98% <100.00%> (ø)
key-wallet-ffi/src/managed_wallet.rs 81.34% <50.00%> (+2.16%) ⬆️
key-wallet-ffi/src/transaction.rs 0.00% <0.00%> (ø)
.../src/managed_account/managed_account_collection.rs 55.66% <33.33%> (ø)
...t/src/managed_account/managed_core_keys_account.rs 55.12% <86.66%> (+55.12%) ⬆️
...wallet/src/transaction_checking/account_checker.rs 67.02% <81.81%> (ø)
... and 4 more

... and 16 files with indirect coverage changes