Skip to content

refactor(key-wallet): wire ManagedCoreKeysAccount into the collection#742

Merged
QuantumExplorer merged 9 commits into
v0.42-devfrom
claude/wire-managed-keys-account
May 7, 2026
Merged

refactor(key-wallet): wire ManagedCoreKeysAccount into the collection#742
QuantumExplorer merged 9 commits into
v0.42-devfrom
claude/wire-managed-keys-account

refactor(key-wallet): keep `from_account_collection` field-direct ins…

142c6e5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2026 in 1s

71.21% (-0.15%) compared to 478af3b

View this Pull Request on Codecov

71.21% (-0.15%) compared to 478af3b

Details

Codecov Report

❌ Patch coverage is 58.06112% with 398 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.21%. Comparing base (478af3b) to head (142c6e5).

Files with missing lines Patch % Lines
.../src/managed_account/managed_account_collection.rs 58.94% 101 Missing ⚠️
...-wallet/src/managed_account/managed_account_ref.rs 56.75% 80 Missing ⚠️
...wallet/src/transaction_checking/account_checker.rs 70.90% 80 Missing ⚠️
key-wallet-ffi/src/managed_account.rs 51.37% 53 Missing ⚠️
...t/src/managed_account/managed_core_keys_account.rs 41.50% 31 Missing ⚠️
key-wallet-ffi/src/address_pool.rs 0.00% 30 Missing ⚠️
...y-wallet/src/wallet/managed_wallet_info/helpers.rs 42.10% 11 Missing ⚠️
key-wallet-ffi/src/managed_account_collection.rs 25.00% 6 Missing ⚠️
...src/wallet/managed_wallet_info/managed_accounts.rs 53.84% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #742      +/-   ##
=============================================
- Coverage      71.35%   71.21%   -0.15%     
=============================================
  Files            320      321       +1     
  Lines          69370    70070     +700     
=============================================
+ Hits           49497    49897     +400     
- Misses         19873    20173     +300     
Files with missing lines Coverage Δ
...-wallet/src/transaction_checking/wallet_checker.rs 99.21% <ø> (ø)
...c/wallet/managed_wallet_info/asset_lock_builder.rs 79.61% <100.00%> (ø)
...allet/managed_wallet_info/wallet_info_interface.rs 83.22% <100.00%> (ø)
key-wallet-ffi/src/managed_account_collection.rs 30.34% <25.00%> (-1.50%) ⬇️
...src/wallet/managed_wallet_info/managed_accounts.rs 21.27% <53.84%> (+1.42%) ⬆️
...y-wallet/src/wallet/managed_wallet_info/helpers.rs 43.45% <42.10%> (+8.37%) ⬆️
key-wallet-ffi/src/address_pool.rs 34.27% <0.00%> (-6.39%) ⬇️
...t/src/managed_account/managed_core_keys_account.rs 51.90% <41.50%> (-7.07%) ⬇️
key-wallet-ffi/src/managed_account.rs 57.41% <51.37%> (+5.27%) ⬆️
...-wallet/src/managed_account/managed_account_ref.rs 56.75% <56.75%> (ø)
... and 2 more

... and 9 files with indirect coverage changes