Skip to content

fix(key-wallet): platform node id is the Tenderdash node ID (SHA256[0..20]), not hash160#884

Merged
QuantumExplorer merged 4 commits into
devfrom
claude/platform-node-id-883
Jul 14, 2026
Merged

fix(key-wallet): platform node id is the Tenderdash node ID (SHA256[0..20]), not hash160#884
QuantumExplorer merged 4 commits into
devfrom
claude/platform-node-id-883

refactor(key-wallet): use infallible conversions for node-id bytes

90f02c5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 14, 2026 in 0s

74.30% (+0.07%) compared to bc6cbf9

View this Pull Request on Codecov

74.30% (+0.07%) compared to bc6cbf9

Details

Codecov Report

❌ Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.30%. Comparing base (bc6cbf9) to head (90f02c5).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
key-wallet/src/managed_account/address_pool.rs 44.44% 5 Missing ⚠️
key-wallet/src/account/eddsa_account.rs 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #884      +/-   ##
==========================================
+ Coverage   74.23%   74.30%   +0.07%     
==========================================
  Files         326      326              
  Lines       74585    74636      +51     
==========================================
+ Hits        55370    55462      +92     
+ Misses      19215    19174      -41     
Files with missing lines Coverage Δ
key-wallet/src/derivation_slip10.rs 51.75% <100.00%> (+0.68%) ⬆️
...wallet/src/transaction_checking/account_checker.rs 53.98% <ø> (ø)
key-wallet/src/account/eddsa_account.rs 76.05% <95.83%> (+4.46%) ⬆️
key-wallet/src/managed_account/address_pool.rs 66.75% <44.44%> (-0.36%) ⬇️

... and 10 files with indirect coverage changes