Skip to content

fix(dash-spv): don't preload filters below the actually stored range on filter-download start#893

Merged
xdustinface merged 2 commits into
devfrom
fix/filter-preload-sparse-storage
Jul 15, 2026
Merged

fix(dash-spv): don't preload filters below the actually stored range on filter-download start#893
xdustinface merged 2 commits into
devfrom
fix/filter-preload-sparse-storage

fix(dash-spv): address CodeRabbit review on sparse-filter preload fix

828f707
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 14, 2026 in 0s

74.44% (+0.05%) compared to 38c689d

View this Pull Request on Codecov

74.44% (+0.05%) compared to 38c689d

Details

Codecov Report

❌ Patch coverage is 97.73585% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.44%. Comparing base (38c689d) to head (828f707).

Files with missing lines Patch % Lines
dash-spv/src/storage/mod.rs 0.00% 4 Missing ⚠️
dash-spv/src/storage/segments.rs 98.27% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #893      +/-   ##
==========================================
+ Coverage   74.39%   74.44%   +0.05%     
==========================================
  Files         327      327              
  Lines       74779    75032     +253     
==========================================
+ Hits        55629    55855     +226     
- Misses      19150    19177      +27     
Files with missing lines Coverage Δ
dash-spv/src/storage/filters.rs 100.00% <100.00%> (ø)
dash-spv/src/sync/filters/manager.rs 97.74% <100.00%> (+0.13%) ⬆️
dash-spv/src/storage/segments.rs 96.15% <98.27%> (+0.34%) ⬆️
dash-spv/src/storage/mod.rs 86.15% <0.00%> (-1.08%) ⬇️

... and 4 files with indirect coverage changes