dev/issues-4#247
Open
luk384090-cloud wants to merge 5 commits into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
lzsweb
reviewed
Jul 22, 2026
added 3 commits
July 24, 2026 10:53
…rmed/empty responses - Add null/empty message checks and try-catch for all JsonUtils.parse call sites (WebSocket, HTTP, isFlattenResult, encrypted branches) using PublicErrorDef.INTERNAL_ERROR - Introduce PublicErrorDef (copied from com.alibaba.dashscope:error:1.0.0) for standardized error codes and messages
…sponse redundancy Extracted setInternalError(), parseJson(), populateFromHttpJson(), and fromWebSocketMessage() to eliminate repeated error-handling and JSON field extraction across three fromResponse() overloads.
lzsweb
reviewed
Jul 24, 2026
| : payload.get(ApiKeywords.USAGE)); | ||
| } | ||
| } | ||
| fromWebSocketMessage(response.getMessage()); |
Collaborator
There was a problem hiding this comment.
response.getMessage() 需要做下防御
| } | ||
| this.output = jsonObject; | ||
| } | ||
| populateFromHttpJson(jsonObject); |
Collaborator
There was a problem hiding this comment.
jsonObject.has(ApiKeywords.OUTPUT) 和 jsonObject.has(ApiKeywords.DATA) 都对this.output赋值？
| } | ||
|
|
||
| private void populateFromHttpJson(JsonObject jsonObject) { | ||
| if (jsonObject.has(ApiKeywords.OUTPUT)) { |
| : ""); | ||
| if (jsonObject.has(ApiKeywords.DATA)) { | ||
| jsonObject.remove(ApiKeywords.REQUEST_ID); | ||
| this.output = jsonObject; |
| } | ||
| JsonObject jsonObject = | ||
| parseJson(encryptedMessage, "Failed to parse encrypted HTTP response message"); | ||
| if (jsonObject == null) return (T) this; |
| jsonObject.remove(ApiKeywords.REQUEST_ID); | ||
| } | ||
| this.output = parseJson(plainOutput, "Failed to parse decrypted output"); | ||
| if (this.output == null) return (T) this; |
Collaborator
There was a problem hiding this comment.
应该是：
} else {
this.output = null;
}
| this.output = parseJson(plainOutput, "Failed to parse decrypted output"); | ||
| if (this.output == null) return (T) this; | ||
| } | ||
| populateFromHttpJson(jsonObject); |
Collaborator
There was a problem hiding this comment.
将2个output 移出函数。
if (jsonObject.has(ApiKeywords.OUTPUT)) {
this.output =
jsonObject.get(ApiKeywords.OUTPUT).isJsonNull()
? null
: jsonObject.get(ApiKeywords.OUTPUT).getAsJsonObject();
}
populateFromHttpJson(jsonObject);
if (jsonObject.has(ApiKeywords.DATA)) {
this.output = jsonObject;
}
| ? jsonObject.get(ApiKeywords.MESSAGE).getAsString() | ||
| : ""); | ||
| if (jsonObject.has(ApiKeywords.DATA)) { | ||
| jsonObject.remove(ApiKeywords.REQUEST_ID); |
| return (T) this; | ||
| } | ||
| JsonObject jsonObject = parseJson(message, "Failed to parse HTTP response as JSON: {}"); | ||
| if (jsonObject == null) return (T) this; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.