Skip to content

feat(cli): enhance CLI error handling and robustness#159

Merged
luk384090-cloud merged 9 commits into
mainfrom
dev/sdk-cli-1
Jul 9, 2026
Merged

feat(cli): enhance CLI error handling and robustness#159
luk384090-cloud merged 9 commits into
mainfrom
dev/sdk-cli-1

Conversation

@luk384090-cloud

Copy link
Copy Markdown
Collaborator

Description

[Describe what this PR does and why]

Related Issue: Fixes #[issue_number] or Relates to #[issue_number]

Security Considerations: [Check if API keys or sensitive credentials are exposed in code/logs]

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Model
  • Application
  • Common
  • Documentation
  • Tests
  • CI/CD

Checklist

  • Pre-commit hooks pass
  • Tests pass locally
  • Documentation updated (if needed)
  • Ready for review

Testing

[How to test these changes]

Additional Notes

[Optional: any other context]

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates and hides the code-generation and understanding CLI commands, while significantly improving robustness across multiple CLI modules (including agentic_rl, deployments, files, fine_tunes, speech_synthesis, and common). These improvements include adding timeout limits for waiting operations, validating that API outputs are not None or of unexpected types before accessing attributes, and enhancing the common response validation helper to catch business-level errors even on HTTP 200 responses. Feedback was provided on dashscope/cli/common.py to make the business error check more robust against potential AttributeErrors if the response output is not a dictionary.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dashscope/cli/common.py Outdated
zhansheng.lzs and others added 8 commits July 7, 2026 15:34
- Add DASHSCOPE to ModelProtocol enum for native DashScope API support
- Update agentic RL tests to use DashScope protocol instead of OpenAI
- Add clarifying comments for qwen3-asr-flash model in samples
- Remove unnecessary base_address override in tingwu sample

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Add NOTICE file declaring certifi dependency under MPL-2.0 and include
LICENSE.certifi from the official repository. Update MANIFEST.in to
ensure both files are bundled in distribution packages.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@luk384090-cloud
luk384090-cloud merged commit 826fee9 into main Jul 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants