Support cancel in finish-task and payload parameters in multimodal dialog#163
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for a cancel directive in the speech synthesizer's finish request and refactors streaming_cancel to support a timeout when waiting for the task-finished event. It also adds pass_through_params to RequestToRespondParameters in the multimodal request parameters. Feedback on these changes highlights two issues in streaming_cancel: first, the connection is not actually force-closed on timeout if _close_ws_after_use is false, despite the log message claiming so; second, the docstring incorrectly states that a TimeoutError is raised on timeout, whereas only a warning is logged. A code suggestion is provided to resolve these issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
2 participants
No description provided.