Ensure workers use private ip to connect to scheduler#394
Merged
jacobtomlinson merged 4 commits intoFeb 9, 2023
Merged
Conversation
jacobtomlinson
requested changes
Dec 28, 2022
jacobtomlinson
left a comment
jacobtomlinson
left a comment
Member
There was a problem hiding this comment.
Thanks! This seems like a great enhancement and we should be doing this everywhere. Instead of special casing Azure I'd rather implement this in a way that allows us to implement it for other clouds easily in the future. See my commments.
jacobtomlinson
approved these changes
Feb 9, 2023
jacobtomlinson
left a comment
jacobtomlinson
left a comment
Member
There was a problem hiding this comment.
Awesome thanks. Sorry for the delay in coming back here.
…m-workers-connect-privately-to-scheduler
Member
|
Pulled from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to address #254
Overview
Let the scheduler and dashboard be publicly adressable with the workers in a vnet. The workers will always connect to the scheduler using the private IP, regardless of whether the scheduler has a public IP or not.
self.addressis the private IPself.external_addressis the public IP on the scheduler object if public_ingress=TrueTesting
Confirmed that it works by creating a cluster with
public_ingress = Trueand a vnet allowing traffic on ports 8786-8787 from IP of local laptop only. Without this fix, the workers try to communicate with the scheduler using the public IP.