Generalize DataFrame backend for remaining tests#246
Merged
Conversation
phofl
reviewed
Jul 26, 2023
phofl
approved these changes
Jul 27, 2023
Collaborator
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #212 - It simplifies the way we set the DataFrame backend for testing, and uses the same mechanism for all py-test modules.
Note that I added a bit of code to avoid cases where the
cudfbackend was previously hanging. However, I made no attempt to fix any pandas-specific logic. Therefore, there are many tests that still fail for the cudf backend. Now it is just much easier to run the test suite to see what fails :)