Switch to pyproject.toml package setup

[GenevieveBuckley]

Closes #305

[m-albert]

I've noticed that setup.py is explicitly referenced in several places: https://github.com/search?q=repo%3Adask%2Fdask-image+setup.py&type=code

Perhaps most critically in

dask-image/.github/workflows/test_and_deploy.yml

Line 90 in 264bd1d

python setup.py sdist bdist_wheel

(replacement might be python -m build? Not sure whether build would need to be added as a dependency)

and

dask-image/continuous_integration/gpuci/build.sh

Line 47 in 264bd1d

python setup.py install

underlying the gpuci failure (replacement might be python -m pip install -e . ?).

[jakirkham]

Yeah in terms of CI changes with setup.py. Would suggest going the pip install route for now. That is pretty close to what we were doing before

[jakirkham]

Thanks Genevieve! 🙏

Think this is coming along nicely 😄

Tried to help answer some questions and suggest some small changes on some of the trickier pieces

[jakirkham]

Whether to keep versioneer.py here depends on the versioning decision above ( #306 (comment) )

[m-albert]

The conflict is probably due to PR ( #336 ). Though think we can just delete the file again during conflict resolution

I merged main to start testing this branch

[m-albert]

The gpuCI fails with the following errpr:

09:53:55 python: can't open file '/workspace/setup.py': [Errno 2] No such file or directory

Could it be that "setup.py" is mentioned somewhere in the Jenkins configuration?

[jakirkham]

From CI:

python: can't open file '/workspace/setup.py': [Errno 2] No such file or directory

Looks like this code needs an update:

dask-image/continuous_integration/gpuci/build.sh

Lines 46 to 47 in b23b615

	rapids-logger "Install dask-image"
	python setup.py install

Edit: It is probably worth using git grep to find any more setup.py references and replacing them. A quick GH search reveals a few setup.py usages (notably in docs)

[m-albert]

I had overseen the code you referenced somehow, thanks for the clarification John 🙏

@GenevieveBuckley Would you like me to help completing this PR?

[GenevieveBuckley]

PR #370 adds python 3.12 support. This PR should also have python 3.12 support.

[GenevieveBuckley]

@GenevieveBuckley Would you like me to help completing this PR?

Sorry I didn't see your message earlier @m-albert
Of course, if you want to give it a go I'm very happy for you to do that 😄

[GenevieveBuckley]

Decision: I'm going to try replacing versioneer with setuptools-scm as part of this PR.
It seems simpler for maintenance, and looks like it will have better long term support. Fingers crossed for a smooth transition 🤞

[GenevieveBuckley]

Ok, done. There's still a few GPU CI things left to take care of, and that work is happening in separate PRs.

[jakirkham]

Hooray! 🎉

Thanks Genevieve! 🙏

[m-albert]

@GenevieveBuckley 🚀