Update GPU conda environment before running tests#318
Merged
Conversation
Closed
jakirkham
reviewed
May 15, 2023
Comment on lines
-43
to
-45
| # gpuci_logger "Install dask" | ||
| # python -m pip install git+https://github.com/dask/dask | ||
|
|
Member
There was a problem hiding this comment.
Wonder if we should add the Dask nightly channel ( dask/label/dev ) to the environment files used by CI
Member
Author
There was a problem hiding this comment.
Would this change anything in terms of what Dask version is getting picked up? IIUC all the dask-image CI files use a pinned Dask version.
In general I'm okay with unpinning & installing a nightly Dask version as part of GPU CI, though might also be worth exploring if this is something we would like to do for CPU CI as well
Member
There was a problem hiding this comment.
Yeah this is a good point. Maybe we can raise an issue and follow up later
Member
|
Thanks Charles! 🙏 Generally this seems reasonable. Had a somewhat tangentially related question above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to update the conda environment in the GPU CI images before running tests, which should hopefully allow us to capture environment changes like those made in #315 without needing to rebuild images.