Skip to content

Workaround for the sphinx version problem in the readthedocs build environment#354

Merged
jakirkham merged 2 commits intodask:mainfrom
m-albert:fix_rtd_dependencies
Feb 26, 2024
Merged

Workaround for the sphinx version problem in the readthedocs build environment#354
jakirkham merged 2 commits intodask:mainfrom
m-albert:fix_rtd_dependencies

Conversation

@m-albert
Copy link
Copy Markdown
Collaborator

This PR addresses #351 by implementing dask/dask-sphinx-theme#68 (comment).

Further discussions here readthedocs/readthedocs.org#11140.

Copy link
Copy Markdown
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marvin! 🙏

Only suggestion would to put the comment before all of the pip requirements

@jakirkham jakirkham mentioned this pull request Feb 24, 2024
Co-authored-by: jakirkham <jakirkham@gmail.com>
@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Feb 26, 2024

One of the gpuCI jobs crashed, restarted it

Edit: Looks like that fixed it

@jakirkham jakirkham merged commit a6c0b93 into dask:main Feb 26, 2024
@jakirkham
Copy link
Copy Markdown
Member

Thanks Marvin! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants