Unified test suite

[mrocklin]

After we figure out CI testing in #2 we might consider refactoring the test suite into a unified TestCase class for common functionality.

[jakirkham]

So are you wanting to use unittest or are you only thinking the organization structure of a class would be nice?

[mrocklin]

No strong preference. What do you think is best? I would probably default to unittest just because that's what I've done before. That's not a very good reason on it's own though :)

[jakirkham]

Sure, using unittest is fine. Thought about pytest too. Though don't have any better arguments for it. :)

[mrocklin]

Given that we will be using pytest we can probably at least avoid the self.assertFoo methods :)

…

On Fri, Mar 2, 2018 at 11:07 AM, jakirkham ***@***.***> wrote: Sure, using unittest is fine. Thought about pytest too. Though don't have any better arguments for it. :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASszNzEN4EHnHHOVwx6EDMsKKoDJiAxks5taW5CgaJpZM4SZ3u4> .

[guillaumeeb]

Do we need to do something here? Or is the current configuration good enough? I admit I don't quite understand what is being suggested by @mrocklin at first.

[mrocklin]

My original suggestion was to create a unittest.TestCase subclass that contains a set of tests, but that needs a bit of specialization to each cluster type.

class TestBasic(unittest.TestCase):
    Cluster = None
    def test_cores(self):
        with self.Cluster(cores=4, processes=2) as cluster:
            cluster.scale(2)
            ... wait a bit ...
            with Client(cluster) as client:
                info = client.scheduler_info()
                assert len(info['workers']) == 4
                ... more assertions
    
    def test_header(self):
        ...

    def test_foo(self):
        ...

class TestPBSCluster(TestBasic):
    Cluster = PBSCluster

[mrocklin]

I'm not sure how much reuse there is though. This might or might not make sense.