Skip to content

Initial Travis configuration (rebased and fixed)#23

Merged
jhamman merged 10 commits into
dask:masterfrom
lesteve:travis
Mar 27, 2018
Merged

Initial Travis configuration (rebased and fixed)#23
jhamman merged 10 commits into
dask:masterfrom
lesteve:travis

Conversation

@lesteve

@lesteve lesteve commented Mar 27, 2018

Copy link
Copy Markdown
Member

I fixed the conflicts in #13 and got Travis working on my fork, see this Travis build.

Closes #13.

I would have opened a PR on @jhamman fork but because of the conflicts this is not very convenient so I opened a new PR instead.

@lesteve

lesteve commented Mar 27, 2018

Copy link
Copy Markdown
Member Author

Full disclosure: I am certainly not a docker expert, so I did the minimal change to get Travis to work without guarantee that this follows best docker practices.

@mrocklin

Copy link
Copy Markdown
Member

I'm very glad to see you working on this @lesteve :) I'm curious have you been using dask-jobqueue on your own?

Also, to reduce build times we might want to add the nomkl package to the environment.

@jhamman

jhamman commented Mar 27, 2018

Copy link
Copy Markdown
Member

@lesteve - this makes me very happy to see. Thanks for stepping up. No strong objections from me on the changes you made.

@mrocklin

Copy link
Copy Markdown
Member

It works! That's quite exciting :)

Now we just need to make an SGE system, which should be comparatively easy :)

@mrocklin

Copy link
Copy Markdown
Member

@jhamman now that we have a system in place do you think some of the system administrators at NCAR would have time an interest in submitting a solution for PBS?

@lesteve

lesteve commented Mar 27, 2018

Copy link
Copy Markdown
Member Author

I'm very glad to see you working on this @lesteve :) I'm curious have you been using dask-jobqueue on your own?

Happy this is useful! I have been watching dask-drmaa and dask-jobqueue lately with the not-so-far-in-the-future goal to make our local SGE cluster more user-friendly for researchers. I have used only dask-drmaa so far and only for toy problems.

@mrocklin

mrocklin commented Mar 27, 2018 via email

Copy link
Copy Markdown
Member

@lesteve

lesteve commented Mar 27, 2018

Copy link
Copy Markdown
Member Author

It would be great, I definitely plan to try test dask on our SGE cluster more extensively by then!

@mrocklin

mrocklin commented Mar 27, 2018 via email

Copy link
Copy Markdown
Member

@guillaumeeb

Copy link
Copy Markdown
Member

@mrocklin @jhamman, I was thinking about working on a comparable solution for PBS. But if someone else is willing to work on this that's fine with me.

Maybe we should open a specific issue for PBS, and same with Slurm?

@mrocklin

mrocklin commented Mar 27, 2018 via email

Copy link
Copy Markdown
Member

@mrocklin

Copy link
Copy Markdown
Member

@jhamman ok to merge?

@jhamman jhamman merged commit 2e73126 into dask:master Mar 27, 2018
@lesteve lesteve deleted the travis branch March 27, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants