Skip to content

Switch to use_stdin=True by default for LSFCluster. #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesteve merged 3 commits into from
Mar 5, 2020
Merged

Switch to use_stdin=True by default for LSFCluster. #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86510a4
Switch to use_stdin=True for LSFCluster.
lesteve Mar 5, 2020
e22f3d1
Add changelog.
lesteve Mar 5, 2020
e412db7
Fix
lesteve Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dask_jobqueue/jobqueue.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ jobqueue:
job-extra: []
log-directory: null
lsf-units: null
use-stdin: null # (bool) How jobs are launched, i.e. 'bsub jobscript.sh' or 'bsub < jobscript.sh'
use-stdin: True # (bool) How jobs are launched, i.e. 'bsub jobscript.sh' or 'bsub < jobscript.sh'

htcondor:
name: dask-worker
Expand Down
2 changes: 0 additions & 2 deletions dask_jobqueue/lsf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ def __init__(

if use_stdin is None:
use_stdin = dask.config.get("jobqueue.%s.use-stdin" % self.config_name)
if use_stdin is None:
use_stdin = lsf_version() < "10"
self.use_stdin = use_stdin

header_lines = []
Expand Down
1 change: 1 addition & 0 deletions docs/source/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Development version
of threads per process is roughly the same. Old default was to use one
process and only threads, i.e. ``proccesses=1``, ``threads_per_process=cores``.
- fix bug (forgotten async def) in ``OARCluster._submit_job`` (:pr:`380`).
- ``LSFCluster``: switch to ``use_stdin=True`` (:pr:`388`).

0.7.0 / 2019-10-09
------------------
Expand Down