Skip to content

JobQueueCluster: pass security along#397

Closed
bfis wants to merge 1 commit into
dask:masterfrom
bfis:patch-1
Closed

JobQueueCluster: pass security along#397
bfis wants to merge 1 commit into
dask:masterfrom
bfis:patch-1

Conversation

@bfis

@bfis bfis commented Mar 23, 2020

Copy link
Copy Markdown
Contributor

JobQueueCluster.__init__ needs to pass the security argument to it's super's (SpecCluster) __init__ since it is needed there too.

JobQueueCluster.__init__ needs to pass the security argument to it's super's (SpecCluster) __init__ since it is needed there too.
@lesteve

lesteve commented Mar 24, 2020

Copy link
Copy Markdown
Member

Thanks for your PR!

I have noticed that recently too. I have some ongoing branch with a broader scope trying to tackle #386 and fixing some quirks while doing that. Edit: I ended up opening a WIP PR #398

It may take a week before I manage to clean it up a bit and add tests though, plus maybe one week of review.

Here are a few of the options that you have available:

  • you manage to extract the Security fix from my branch and add them to this PR with some tests. You can see that you need to do a bit more than adding the paramater.
  • if you have some spare bandwidth fixing protocol as well would be very welcome (probably a bit easier than adding security)
  • you help me on my branch by doing PRs on my branch, for example by testing it on your cluster and/or adding more tests

By the way if you have a use case for using security in a HPC context I would be quite interested to hear more about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants