JobQueueCluster: pass security along#397
Closed
bfis wants to merge 1 commit into
Closed
Conversation
JobQueueCluster.__init__ needs to pass the security argument to it's super's (SpecCluster) __init__ since it is needed there too.
Member
|
Thanks for your PR! I have noticed that recently too. I have some ongoing branch with a broader scope trying to tackle #386 and fixing some quirks while doing that. Edit: I ended up opening a WIP PR #398 It may take a week before I manage to clean it up a bit and add tests though, plus maybe one week of review. Here are a few of the options that you have available:
By the way if you have a use case for using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JobQueueCluster.__init__needs to pass thesecurityargument to it's super's (SpecCluster)__init__since it is needed there too.