-
-
Notifications
You must be signed in to change notification settings - Fork 150
Allow scheduler options import from configuration file #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1044101
ab5571e
e408dd6
b06788f
331d967
13d1331
c4e4ada
cc22dc8
43fde67
2add42a
60fb8ee
20bddf0
e00042f
e1bf1bd
6e674b1
df3b7ff
9bc8068
29f3491
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -477,7 +477,9 @@ def __init__( | |
| if interface is None: | ||
| interface = dask.config.get("jobqueue.%s.interface" % config_name) | ||
| if scheduler_options is None: | ||
| scheduler_options = {} | ||
| scheduler_options = dask.config.get( | ||
| "jobqueue.%s.scheduler-options" % config_name, {} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you explain me why the
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The "problem" is that the configuration dictionaries used for testing are all set up explicitely, and thus won't inherit from Instead of having it would also be possible to add However, then we would actually require the existence of a
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
OK fair enough, for not breaking backward-compatibility, let's keep the |
||
| ) | ||
|
|
||
| default_scheduler_options = { | ||
| "protocol": protocol, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.