Skip to content

add temporary security if set to True#527

Merged
guillaumeeb merged 1 commit into
dask:mainfrom
riedel:temporary_security_if_true_525
Dec 4, 2021
Merged

add temporary security if set to True#527
guillaumeeb merged 1 commit into
dask:mainfrom
riedel:temporary_security_if_true_525

Conversation

@riedel

@riedel riedel commented Oct 20, 2021

Copy link
Copy Markdown
Member

add cryptography dependency to htcondor testing
fix extra_dependency for testing: tests_require seems to be deprecated

Fixes #525

@riedel

riedel commented Oct 20, 2021

Copy link
Copy Markdown
Member Author

This one requires #520 to be fixed. Using temporary certs will cause the test to be hanging.

There is one remaining problem with htcondor as the cryptography dependency cannot be installed using pip due to a missing whl.

@riedel

riedel commented Dec 4, 2021

Copy link
Copy Markdown
Member Author

rebased on #524 to actually check if the prerequisites are given

@riedel riedel force-pushed the temporary_security_if_true_525 branch 6 times, most recently from ee45c6f to 931e280 Compare December 4, 2021 10:55
@riedel riedel marked this pull request as ready for review December 4, 2021 11:02
@riedel

riedel commented Dec 4, 2021

Copy link
Copy Markdown
Member Author

needs to be rebased once #524 is merged.

@riedel riedel force-pushed the temporary_security_if_true_525 branch from 931e280 to 71e3fd8 Compare December 4, 2021 14:04
@riedel riedel removed the blocked Awaiting the output of some other work label Dec 4, 2021
@riedel

riedel commented Dec 4, 2021

Copy link
Copy Markdown
Member Author

@guillaumeeb: many thanks for merging #524!! This is the last remaining bit of the bunch of PRs. This, however, is not much of a priority. It just aligns things a bit with other cluster implementations for convenience..

@guillaumeeb guillaumeeb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @riedel!

@guillaumeeb guillaumeeb merged commit 4980e74 into dask:main Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

all job schedulers enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create temporary security context by default if security is set to True

2 participants