Skip to content

re-assigning worker_extra_args instead of altering it with += #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumeeb merged 1 commit into from
Oct 3, 2022
Merged

re-assigning worker_extra_args instead of altering it with += #591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dask_jobqueue/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,9 @@ def __init__(
self.job_header = None

if interface:
worker_extra_args += ["--interface", interface]
worker_extra_args = worker_extra_args + ["--interface", interface]
if protocol:
worker_extra_args += ["--protocol", protocol]
worker_extra_args = worker_extra_args + ["--protocol", protocol]
if security:
worker_security_dict = security.get_tls_config_for_role("worker")
security_command_line_list = [
Expand All @@ -318,7 +318,7 @@ def __init__(
if key != "ciphers"
]
security_command_line = sum(security_command_line_list, [])
worker_extra_args += security_command_line
worker_extra_args = worker_extra_args + security_command_line

# Keep information on process, cores, and memory, for use in subclasses
self.worker_memory = parse_bytes(memory) if memory is not None else None
Expand Down