Skip to content

Bump minimum Python to 3.9#652

Merged
jacobtomlinson merged 5 commits into
dask:mainfrom
jacobtomlinson:sge-double-free
Aug 6, 2024
Merged

Bump minimum Python to 3.9#652
jacobtomlinson merged 5 commits into
dask:mainfrom
jacobtomlinson:sge-double-free

Conversation

@jacobtomlinson

Copy link
Copy Markdown
Member

Dask dropped 3.8 support in dask/community#315. This PR makes 3.9 the minimum version here.

@jacobtomlinson

Copy link
Copy Markdown
Member Author

Dask Jobqueue uses container images in CI that were built by the latest run on main. So int his case those images still use 3.8. In this PR I changed things to build instead of pull to ensure things work with 3.9.

Everything is passing except for the known SGE test issue (see #653) so I'm confident with the changes here. I'm going to revert the builds back to pulls and merge which should get things happy again once main is built.

@jacobtomlinson

Copy link
Copy Markdown
Member Author

Looking at the times here it actually only took a couple of minutes to build the containers. Pull an image built from a previous branch feels a little funny and causes a headache in PRs like this. So I'm going to leave the builds in here instead of the pulls. We can always revert this in the future if it becomes a problem, or explore caching the images in a different way.

@jacobtomlinson jacobtomlinson merged commit af936b5 into dask:main Aug 6, 2024
@jacobtomlinson jacobtomlinson deleted the sge-double-free branch August 6, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant