Skip to content

[MRG] Run against scikit-learn dev (rebased)#117

Merged
TomAugspurger merged 10 commits into
dask:masterfrom
lesteve:scikit-learn-dev
Jan 22, 2018
Merged

[MRG] Run against scikit-learn dev (rebased)#117
TomAugspurger merged 10 commits into
dask:masterfrom
lesteve:scikit-learn-dev

Conversation

@lesteve

@lesteve lesteve commented Jan 22, 2018

Copy link
Copy Markdown
Member

Mostly a rebase of #46 with a tentative fix. Closes #46.

@lesteve lesteve force-pushed the scikit-learn-dev branch 4 times, most recently from 998fcab to 39913d8 Compare January 22, 2018 13:07
@lesteve

lesteve commented Jan 22, 2018

Copy link
Copy Markdown
Member Author

It seems to be working now. A brief summary:

  • add ci/install-circle.sh to share install script across builds (similar to the original PR)
  • add sklearn_dev build similarly to the original PR
  • minor fixes (the main one was to install g++ compared to the original PR)

@TomAugspurger

Copy link
Copy Markdown
Member

Thanks!

@TomAugspurger TomAugspurger merged commit bb53c54 into dask:master Jan 22, 2018
@lesteve lesteve deleted the scikit-learn-dev branch January 22, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants