TST: make sure Incremental works with dataframes#458
Merged
Conversation
This test passes with dask 1.1.1.
stsievert
force-pushed
the
incremental-and-dataframes
branch
from
378e281 to
769ed6f
Compare
stsievert
changed the title
Member
Author
|
This is no longer a work in progress, and ready for review (and maybe merge). I had to rebase off #455 to make the tests work. |
Member
|
Maybe one more merge of master? I think CI should be passing again. |
TomAugspurger
approved these changes
Apr 5, 2019
Member
Author
|
The CI tests for this PR are passing. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement?
This PR makes sure that dataframes work with Incremental. For tests, I modify the basic incremental test and pass both Dask arrays and dataframes.
Reference issues/PRs