Skip to content

fix scale / avoid returning coroutines #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrocklin merged 3 commits into from
Aug 8, 2018
Merged

fix scale / avoid returning coroutines #2171

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad02560
avoid returning coroutines in scale
Aug 8, 2018
67f5584
workers kwarg
Aug 8, 2018
2610e85
use logger instead of print
Aug 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions distributed/deploy/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,10 @@ def scale(self, n):
if n >= len(self.scheduler.workers):
self.scheduler.loop.add_callback(self.scale_up, n)
else:
to_close = self.scheduler.retire_workers(
remove=False,
close_workers=True,
n=len(self.scheduler.workers) - n
)
to_close = self.scheduler.workers_to_close(
n=len(self.scheduler.workers) - n)
logger.debug("Closing workers: %s", to_close)
self.scheduler.loop.add_callback(self.scheduler.retire_workers, workers=to_close)
self.scheduler.loop.add_callback(self.scale_down, to_close)

def _widget_status(self):
Expand Down