Skip to content

Scale by number of cores and memory#2209

Closed
guillaumeeb wants to merge 4 commits into
dask:masterfrom
guillaumeeb:scale_ncores
Closed

Scale by number of cores and memory#2209
guillaumeeb wants to merge 4 commits into
dask:masterfrom
guillaumeeb:scale_ncores

Conversation

@guillaumeeb

@guillaumeeb guillaumeeb commented Aug 24, 2018

Copy link
Copy Markdown
Member

Closes #2208.

Just an initial commit to show how it could look. An associated PR incomming on dask-jobqueue.
There work left with the following tasks:

  • Add some test,
  • Rework the widget?

Widget rework to be discussed.
Reviews welcome.

@guillaumeeb

Copy link
Copy Markdown
Member Author

Feedbacks welcome here, cc @mrocklin @jhamman @lesteve

@guillaumeeb guillaumeeb changed the title WIP scale by number of cores and memory Scale by number of cores and memory Aug 27, 2018
@guillaumeeb

Copy link
Copy Markdown
Member Author

Also ping @jcrist and @jacobtomlinson

@mrocklin

Copy link
Copy Markdown
Member

Given planned churn in this module and the number of other packages that this would impact I'm inclined to wait on this until a future redesign. I wonder if changes should be isolated to downstream packages (like dask-jobqueue) until then? I don't have particularly strong thoughts on this though, I haven't reviewed this in detail.

@guillaumeeb

guillaumeeb commented Sep 19, 2018

Copy link
Copy Markdown
Member Author

This can certainly be isolated into dask-jobqueue, I will try to have a look and see if this can be done elegantly without just copy pasting and overriding scale or adapt method. I've not dealt a lot with super() calls in Python yet.

@quasiben

quasiben commented Nov 7, 2019

Copy link
Copy Markdown
Member

I believe recent SpecCluster work addressed scaling cores/memory

@quasiben quasiben closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scale by number of cores or amount of memory

3 participants