Use async-await on large messages test#2404
Merged
Merged
Conversation
This resolves an intermittent error. Previously the variable x would hang around. After tracking down the reference it seems like the generator structure held onto a frame that held onto `x` sometimes. Now we use async-await in Python 3 and this seems to go away.
mrocklin
force-pushed
the
dont-hold-onto-large-messages-test
branch
from
128205d to
a9cc39b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an intermittent error. Previously the variable x would
hang around.
After tracking down the reference it seems like the generator structure
held onto a frame that held onto
xsometimes. Now we use async-awaitin Python 3 and this seems to go away.