Skip to content

Close connection comm on retry #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrbourbeau merged 2 commits into from
Jan 13, 2020
Merged

Close connection comm on retry #3365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9715658
Close comm connection task before retrying
jrbourbeau Jan 10, 2020
4e76ff9
Switch back to ignoring context manager
jrbourbeau Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions distributed/comm/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
from abc import ABC, abstractmethod, abstractproperty
import asyncio
from datetime import timedelta
import logging
import weakref

import dask
from tornado import gen

from ..metrics import time
from ..utils import parse_timedelta, ignoring
Expand Down Expand Up @@ -211,11 +209,9 @@ def _raise(error):
future = connector.connect(
loc, deserialize=deserialize, **(connection_args or {})
)
with ignoring(gen.TimeoutError):
comm = await gen.with_timeout(
timedelta(seconds=min(deadline - time(), 1)),
future,
quiet_exceptions=EnvironmentError,
with ignoring(asyncio.TimeoutError):
comm = await asyncio.wait_for(
future, timeout=min(deadline - time(), 1)
)
break
if not comm:
Expand Down