Skip to content

Log adaptive error#4422

Merged
jrbourbeau merged 1 commit into
dask:masterfrom
jacobtomlinson:log-adaptive-error
Jan 12, 2021
Merged

Log adaptive error#4422
jrbourbeau merged 1 commit into
dask:masterfrom
jacobtomlinson:log-adaptive-error

Conversation

@jacobtomlinson

Copy link
Copy Markdown
Member

Sometimes adaptive will stop due to an OSError.

This PR logs that error to help with debugging.

@jrbourbeau jrbourbeau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacobtomlinson! FYI test_profile_server is a known flaky test (xref #4251)

@jrbourbeau jrbourbeau merged commit 74e8dc6 into dask:master Jan 12, 2021
Timost pushed a commit to Timost/distributed that referenced this pull request Jan 13, 2021
@gerald732

Copy link
Copy Markdown
Contributor

Are there any other implications if we were to remove self.stop()? It will be ideal for adaptive to be resilient to preemption from remote workers @jacobtomlinson

@jacobtomlinson jacobtomlinson deleted the log-adaptive-error branch March 12, 2021 10:35
@jacobtomlinson

Copy link
Copy Markdown
Member Author

It will be ideal for adaptive to be resilient to preemption from remote workers

Are you seeing this problem? Could you please raise an issue with more information?

@gerald732

Copy link
Copy Markdown
Contributor

It will be ideal for adaptive to be resilient to preemption from remote workers

Are you seeing this problem? Could you please raise an issue with more information?

I've raised an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants