(WIP) Re-introduce "logging" to default config and update docstrings#4642
Draft
hristog wants to merge 5 commits into
Draft
(WIP) Re-introduce "logging" to default config and update docstrings#4642hristog wants to merge 5 commits into
hristog wants to merge 5 commits into
Conversation
* `logging` was removed from the config in 399522b (distributed PR dask#1948), and the assumption made in the present commit is that it was done unintentionally, since docs/source/configuration.rst (dask) wasn't updated at the same time with 399522b. * Later down the line, in response to https://stackoverflow.com/questions/57829474/dask-config-get-cannot-get-anything, (dask PR dask#5374) was merged, which didn't update the documentation either. * The above two facts, combined together, suggest that `logging` must've been removed unintentionally from the config.
* OK: * test_logging_simple * test_logging_extended * test_schema_is_complete * Oustanding: test_logging_file_config
hristog
changed the title
hristog
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #xxxxN/Aadded/ passed (4 updated, 1 still failing, WIP)black distributed/flake8 distributedThe proposed PR:
loggingsection ofdistributed/distributed.yaml.distributed/distributed-schema.yamlaccordingly.Some further details:
"logging"was removed from the config in 399522b (Overhaul configuration #1948), and the assumption made in the present commit is that it was done unintentionally, since docs/source/configuration.rst (dask) wasn't updated around the same time as 399522b.Later down the line, in response to https://stackoverflow.com/questions/57829474/dask-config-get-cannot-get-anything, (Add namespacing to configuration example dask#5374) was merged, which didn't update the documentation either.
The StackOverflow issue has to do with the fact that two different users reported that they were unable to access
dask.config.get('distributed.logging'), which indeed seems to have been unavailable by default since 399522b (Overhaul configuration #1948).Apparently, it's confusing enough for some users, that the documentation suggests that
"logging"should be available by default uponimport dask.distributed.The above two facts, combined together, suggest that
loggingmust've been removed unintentionally from the config.Please, feel free to reject or propose changes (the documentation will probably need to be updated to indicate clearly that
"logging"isn't supposed to be available by default) to this PR, if the"logging"section was intentionally removed fromdistributed.yaml(due to verbosity concerns or otherwise).Some related issues/PRs, for reference: #2839, #2937, #2952.