Skip to content

Skip shuffle tests if pandas / dask.dataframe not installed #5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrbourbeau merged 1 commit into from
Jan 28, 2022
Merged

Skip shuffle tests if pandas / dask.dataframe not installed #5730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions distributed/shuffle/tests/test_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
import asyncio
from typing import TYPE_CHECKING

import pytest

pd = pytest.importorskip("pandas")
pytest.importorskip("dask.dataframe")

import dask
import dask.dataframe as dd
Comment on lines +6 to 12

@crusaderky crusaderky Jan 28, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import pytest
pd = pytest.importorskip("pandas")
pytest.importorskip("dask.dataframe")
import dask
import dask.dataframe as dd
import pytest
dd = pytest.importorskip("dask.dataframe")
import dask

@jrbourbeau jrbourbeau Jan 28, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy is giving a

mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

distributed/shuffle/tests/test_graph.py:25: error: Name "dd.DataFrame" is not defined
distributed/shuffle/tests/test_graph.py:26: error: Name "dd.DataFrame" is not defined
Found 2 errors in 1 file (checked 254 source files)

error. I'm going to revert to what I had originally, which mypy was happy with. Happy to do a follow-up to cleanup, but I'm confident in this PR and want to include it in the release today

from dask.blockwise import Blockwise
Expand Down
4 changes: 2 additions & 2 deletions distributed/shuffle/tests/test_shuffle_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
from collections import Counter
from typing import TYPE_CHECKING

import pandas as pd
import pytest

import dask.dataframe as dd
pd = pytest.importorskip("pandas")
dd = pytest.importorskip("dask.dataframe")

from distributed.utils_test import gen_cluster

Expand Down