Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@

# Make all fixtures available
from distributed.utils_test import * # noqa
from distributed.utils_test import clean_config


@pytest.fixture(autouse=True)
def ensure_config_reset():
with clean_config():
yield


def pytest_addoption(parser):
Expand Down
18 changes: 16 additions & 2 deletions distributed/utils_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import tempfile
import threading
import uuid
import warnings
import weakref
from collections import defaultdict
from collections.abc import Callable
Expand All @@ -27,6 +28,7 @@
from itertools import count
from time import sleep
from typing import Any, Literal
from unittest.mock import patch

from distributed.compatibility import MACOS
from distributed.scheduler import Scheduler
Expand Down Expand Up @@ -225,7 +227,21 @@ def get_ip():
original_config = copy.deepcopy(dask.config.config)


@contextmanager
def clean_config():
"""A contextmanager that ensures the dask config is reset to the original
state during interpreter startup upon exit.
"""
with patch.dict(dask.config.config, original_config, clear=True):
yield


def reset_config():
warnings.warn(
"This methods will be removed soon. Consider using the contextmanager "
"distributed.utils_test.clean_config instead",
DeprecationWarning,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DeprecationWarning,
FutureWarning,

)
dask.config.config.clear()
dask.config.config.update(copy.deepcopy(original_config))
Comment on lines 239 to 246

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider this to be an anti-pattern and would suggest to remove this. utils_test is kind of a public API so we'll need to go through a deprecation cycle.


Expand Down Expand Up @@ -1733,9 +1749,7 @@ def clean(threads=not WINDOWS, instances=True, timeout=1, processes=True):
with check_process_leak(check=processes):
with check_instances() if instances else nullcontext():
with check_active_rpc(loop, timeout):
reset_config()

dask.config.set({"distributed.comm.timeouts.connect": "5s"})
# Restore default logging levels
# XXX use pytest hooks/fixtures instead?
for name, level in logging_levels.items():
Expand Down