Skip to content

Remove cache in iscoroutinefunction to avoid holding on to refs #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjetter merged 1 commit into from
Mar 24, 2022
Merged

Remove cache in iscoroutinefunction to avoid holding on to refs #5985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions distributed/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,21 +1124,8 @@ def color_of(x, palette=palette):
return palette[n % len(palette)]


def _iscoroutinefunction(f):
return inspect.iscoroutinefunction(f) or gen.is_coroutine_function(f)


@functools.lru_cache(None)
def _iscoroutinefunction_cached(f):
return _iscoroutinefunction(f)


def iscoroutinefunction(f):
# Attempt to use lru_cache version and fall back to non-cached version if needed
try:
return _iscoroutinefunction_cached(f)
except TypeError: # unhashable type
return _iscoroutinefunction(f)
return inspect.iscoroutinefunction(f) or gen.is_coroutine_function(f)


@contextmanager
Expand Down