Skip to content

Maybe fix test_worker_waits_for_scheduler #5995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrocklin wants to merge 1 commit into from
Closed

Maybe fix test_worker_waits_for_scheduler #5995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions distributed/tests/test_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ async def test_worker_port_range(s):


@pytest.mark.slow

@fjetter fjetter Mar 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this test run very fast, assuming the timeout in wait_for is reduced. At least after the report is turned off.

@mrocklin mrocklin Mar 25, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It tests that the worker waits for at least three seconds. I though about removing it but I think that it genuinely adds signal.

@gen_test(timeout=60)
@gen_test()
async def test_worker_waits_for_scheduler():
w = Worker("127.0.0.1:8724")
try:
Expand All @@ -321,7 +321,7 @@ async def test_worker_waits_for_scheduler():
else:
assert False
assert w.status not in (Status.closed, Status.running, Status.paused)
await w.close(timeout=0.1)
await w.close(report=False)


@gen_cluster(client=True, nthreads=[("127.0.0.1", 1)])
Expand Down