Skip to content

Fix psutil dio counters none#6093

Merged
mrocklin merged 4 commits into
dask:mainfrom
ungarj:fix_psutil_dio_counters_none
Apr 19, 2022
Merged

Fix psutil dio counters none#6093
mrocklin merged 4 commits into
dask:mainfrom
ungarj:fix_psutil_dio_counters_none

Conversation

@ungarj

@ungarj ungarj commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

Proposed fix for #6089

@GPUtester

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@mrocklin

Copy link
Copy Markdown
Member

@ungarj I apologize for the lack of response here. Can you confirm that this resolves things on your end?

@ungarj

ungarj commented Apr 19, 2022

Copy link
Copy Markdown
Contributor Author

@mrocklin no worries and thanks for reaching out!

Yes, we are running this patch now since ~2 weeks now and have not encountered the issue described in #6089 anymore.

Sorry for not adding a test to verify the behavior but I couldn't come up with a setup which replicates this exact behavior.

@mrocklin mrocklin merged commit 90cc2c1 into dask:main Apr 19, 2022
@mrocklin

Copy link
Copy Markdown
Member

Merging in. Thank you for the contribution @ungarj

Also, I notice that this is your first code contribution to the repository. Welcome!

@ungarj

ungarj commented Apr 19, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for merging! Looking forward to keep contributing if I can! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

psutil causes Nanny to crash

3 participants