Garbage Collect Scheduler TaskState#6275
Closed
sjperkins wants to merge 3 commits into
Closed
Conversation
Member
|
I suggest to focus first on Scheduler and Worker instances before you tackle TaskState. That's a required step but much easier and we can get it merged incrementally |
Member
Author
Thanks. By this I think you mean deal with things in the following way in # Fix leaks here first
if Scheduler._instances:
scheduler = Scheduler._instances.pop()
import objgraph
objgraph.show_backrefs[worker], filename="scheduler.png"
assert not Scheduler._instances
# Fix leaks here second
if Worker._instances:
worker = Worker._instances.pop()
import objgraph
objgraph.show_backrefs[worker], filename="worker.png"
assert not Worker._instances
# Fix leaks here last
if TaskState._instances:
ts = TaskState._instances.pop()
import objgraph
objgraph.show_backrefs([ts], filename="taskstate.png")``` |
Member
Author
|
I'll start a new PR to deal with |
Member
Author
|
Closed in favour of #6281 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #6246
Closes #xxxx
pre-commit run --all-files