Skip to content

Restore install_signal_handlers due to downstream dependencies#6366

Merged
jacobtomlinson merged 1 commit into
dask:mainfrom
hendrikmakait:restore-install_signal_handlers
May 18, 2022
Merged

Restore install_signal_handlers due to downstream dependencies#6366
jacobtomlinson merged 1 commit into
dask:mainfrom
hendrikmakait:restore-install_signal_handlers

Conversation

@hendrikmakait

@hendrikmakait hendrikmakait commented May 18, 2022

Copy link
Copy Markdown
Member

Restores the install_signal_handlers function removed in #6205 due to downstream dependencies in e.g. dask-ctl and dask-kubernetes.

XREF: dask/dask-kubernetes/pull/493
XREF: dask-contrib/dask-ctl/pull/41

  • Tests added / passed
  • Passes pre-commit run --all-files

@jacobtomlinson jacobtomlinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread distributed/cli/utils.py
@hendrikmakait hendrikmakait marked this pull request as ready for review May 18, 2022 13:41
@hendrikmakait hendrikmakait force-pushed the restore-install_signal_handlers branch from 6cb42e5 to 31c9f28 Compare May 18, 2022 13:45
@hendrikmakait hendrikmakait requested a review from graingert May 18, 2022 13:45
@hendrikmakait

hendrikmakait commented May 18, 2022

Copy link
Copy Markdown
Member Author

FYI, I don't have permission to merge, so somebody else will have to take it from here.

@jacobtomlinson jacobtomlinson merged commit ff94776 into dask:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants