deprecate the io_loop and loop kwarg to Server, Worker, and Nanny#6473
Merged
fjetter merged 3 commits intoJun 7, 2022
Merged
Conversation
passing anything other than IOLoop.current() is already unsupported: see dask#6443 (comment)
Contributor
Unit Test Results 15 files ±0 15 suites ±0 6h 30m 4s ⏱️ + 23m 8s For more details on these failures, see this check. Results for commit 476f40b. ± Comparison against base commit 715d7be. ♻️ This comment has been updated with latest results. |
graingert
commented
May 31, 2022
Member
|
Fine by me. cc @jacobtomlinson to keep him in the loop |
gjoseph92
approved these changes
Jun 1, 2022
Comment on lines
+894
to
+895
| if loop is not None: | ||
| warnings.warn("the loop kwarg to start_cluster is deprecated") |
Collaborator
There was a problem hiding this comment.
Since this is an internal test function, it seems better to me to just remove the argument now without a deprecation warning.
Co-authored-by: Gabe Joseph <gjoseph92@gmail.com>
graingert
force-pushed
the
deprecate-io_loop-and-loop-kwarg-to-server-worker-and-nanny
branch
from
12ace1f to
476f40b
Compare
fjetter
approved these changes
Jun 1, 2022
fjetter
left a comment
fjetter
left a comment
Member
There was a problem hiding this comment.
Pending green-ish CI, we're good to go
graingert
deleted the
deprecate-io_loop-and-loop-kwarg-to-server-worker-and-nanny
branch
This was referenced Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
passing anything other than IOLoop.current() is already unsupported: see #6443 (comment)
Refs #6163
pre-commit run --all-files