Skip to content

Robust thread termination in test_watch and test_watch_requires_lock_to_run#6788

Merged
gjoseph92 merged 1 commit into
dask:mainfrom
hendrikmakait:fix-thread-termination-in-watch-tests
Aug 1, 2022
Merged

Robust thread termination in test_watch and test_watch_requires_lock_to_run#6788
gjoseph92 merged 1 commit into
dask:mainfrom
hendrikmakait:fix-thread-termination-in-watch-tests

Conversation

@hendrikmakait

@hendrikmakait hendrikmakait commented Jul 26, 2022

Copy link
Copy Markdown
Member

Addresses CI failure (https://github.com/dask/distributed/runs/7199711175?check_suite_focus=true#step:11:1868) mentioned in #6033 (comment)

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait changed the title Fix thread termination in test_watch and test_watch_requires_lock_to_run Robust thread termination in test_watch and test_watch_requires_lock_to_run Jul 26, 2022
@hendrikmakait hendrikmakait self-assigned this Jul 26, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±    0         15 suites  ±0   5h 54m 29s ⏱️ - 44m 20s
  2 976 tests ±    0    2 885 ✔️  -     1    88 💤 +  1  3 ±0 
21 242 runs   - 822  20 243 ✔️  - 786  996 💤  - 36  3 ±0 

For more details on these failures, see this check.

Results for commit a9ef855. ± Comparison against base commit 55cc1a5.

@jacobtomlinson jacobtomlinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

@hendrikmakait hendrikmakait requested a review from crusaderky July 26, 2022 10:37
@hendrikmakait

Copy link
Copy Markdown
Member Author

CI test failures seem unrelated.

@hendrikmakait hendrikmakait requested a review from gjoseph92 July 26, 2022 10:43
@hendrikmakait hendrikmakait added the bug Something is broken label Jul 26, 2022
@hendrikmakait hendrikmakait requested a review from graingert July 27, 2022 10:40
@gjoseph92 gjoseph92 merged commit 94fe41e into dask:main Aug 1, 2022
gjoseph92 pushed a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants