Fix TypeError in SSLError handling in convert_stream_closed_error#6881
Merged
Conversation
hendrikmakait
commented
Aug 12, 2022
| exc = exc.real_error | ||
| if isinstance(exc, ssl.SSLError): | ||
| if "UNKNOWN_CA" in exc.reason: | ||
| if exc.reason and "UNKNOWN_CA" in exc.reason: |
Member
Author
There was a problem hiding this comment.
Note: It looks like the typing information from typeshed is off: https://github.com/python/typeshed/blob/edc0ecd8579389cc6bb75b343e1001424009c09b/stdlib/ssl.pyi#L33
Collaborator
There was a problem hiding this comment.
Could you raise the issue upstream?
Member
Author
|
CI flake: #6582 |
hendrikmakait
requested review from
crusaderky,
fjetter,
gjoseph92 and
graingert
crusaderky
approved these changes
Aug 12, 2022
gjoseph92
pushed a commit
to gjoseph92/distributed
that referenced
this pull request
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6875
pre-commit run --all-files