Rewrite test_reconnect to use subproc to kill scheduler reliably#6967
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 35m 55s ⏱️ - 7m 18s For more details on these failures, see this check. Results for commit e5a6c2d. ± Comparison against base commit c083790. ♻️ This comment has been updated with latest results. |
fjetter
changed the title
Member
Author
|
🟢 🎉 |
gjoseph92
approved these changes
Aug 29, 2022
gjoseph92
left a comment
gjoseph92
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this. Couple style nits, take them or leave them
Co-authored-by: Gabe Joseph <gjoseph92@gmail.com>
hendrikmakait
approved these changes
Aug 30, 2022
hendrikmakait
left a comment
hendrikmakait
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for taking care of fixing this!
2 tasks
gjoseph92
added a commit
to gjoseph92/distributed
that referenced
this pull request
Oct 31, 2022
…k#6967) Co-authored-by: Gabe Joseph <gjoseph92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that even on a successful run of this test, we get a lot of "AsyncioGroup already closed" etc. errors since we clearly cripple the running scheduler by closing all the internals manually. Particularly the client and worker disconnects can trigger us trying to schedule messages to deal with the loss.
Looking at the test, we can see a lot of CancelledErrors with long tracebacks. I'm wondering if we're simply hitting #6211 and #6847 is not responsible after all but merely changed timing such that we hit this condition more reliably.
Let's see what CI thinks about this theory.