avoid calls to make_current() and make_clear() by using asyncio.run in LoopRunner#7467
Merged
crusaderky merged 12 commits intoJun 16, 2023
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ± 0 20 suites ±0 11h 51m 48s ⏱️ + 8m 20s For more details on these failures, see this check. Results for commit f18f9e7. ± Comparison against base commit 4a0c489. ♻️ This comment has been updated with latest results. |
graingert
force-pushed
the
avoid-calls-to-make-current-make-clear
branch
5 times, most recently
from
be56b65 to
86de36a
Compare
graingert
force-pushed
the
avoid-calls-to-make-current-make-clear
branch
from
86de36a to
f121d04
Compare
…n LoopRunner Closes dask#6784
graingert
force-pushed
the
avoid-calls-to-make-current-make-clear
branch
from
f121d04 to
21c7e40
Compare
gjoseph92
reviewed
Feb 16, 2023
gjoseph92
left a comment
gjoseph92
left a comment
Collaborator
There was a problem hiding this comment.
Some questions about thread-safety, but this seems good to me overall.
Co-authored-by: Gabe Joseph <gjoseph92@gmail.com>
graingert
force-pushed
the
avoid-calls-to-make-current-make-clear
branch
from
621adb7 to
5b279be
Compare
crusaderky
requested changes
Jun 9, 2023
crusaderky
left a comment
crusaderky
left a comment
Collaborator
There was a problem hiding this comment.
Very minor nitpicks only
Co-authored-by: crusaderky <crusaderky@gmail.com>
Co-authored-by: crusaderky <crusaderky@gmail.com>
graingert
commented
Jun 13, 2023
Co-authored-by: crusaderky <crusaderky@gmail.com>
crusaderky
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6784
pre-commit run --all-files