Skip to content

Don't shut down unresponsive workers on gather()#8101

Merged
hendrikmakait merged 1 commit into
dask:mainfrom
crusaderky:gather_closes_workers
Aug 14, 2023
Merged

Don't shut down unresponsive workers on gather()#8101
hendrikmakait merged 1 commit into
dask:mainfrom
crusaderky:gather_closes_workers

Conversation

@crusaderky

@crusaderky crusaderky commented Aug 14, 2023

Copy link
Copy Markdown
Collaborator

This PR plugs the last known case (to me at least) where a GIL blockage will cause computations to fail and workers to be shut down. Happy to hear if there are any more.

CC @fjetter @hendrikmakait

@crusaderky crusaderky requested a review from fjetter as a code owner August 14, 2023 09:21
@crusaderky crusaderky force-pushed the gather_closes_workers branch from fe4341d to b68af81 Compare August 14, 2023 09:23
@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±       0         20 suites  ±0   12h 8m 34s ⏱️ + 1h 51m 7s
  3 758 tests +       1    3 648 ✔️  -     1     106 💤 ±  0  4 +2 
36 352 runs  +1 050  34 597 ✔️ +992  1 750 💤 +55  5 +3 

For more details on these failures, see this check.

Results for commit b68af81. ± Comparison against base commit b3dde5c.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
distributed.tests.test_scheduler ‑ test_gather_bad_worker_removed
distributed.tests.test_scheduler ‑ test_gather_bad_worker[False]
distributed.tests.test_scheduler ‑ test_gather_bad_worker[True]

@crusaderky crusaderky self-assigned this Aug 14, 2023
@crusaderky

Copy link
Copy Markdown
Collaborator Author

All failures seem unreleated; ready for review and merge

@hendrikmakait hendrikmakait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @crusaderky!

@hendrikmakait hendrikmakait merged commit ac5ddc3 into dask:main Aug 14, 2023
@crusaderky crusaderky deleted the gather_closes_workers branch August 14, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gather() should not remove unresponsive workers

2 participants