Auto-fail tasks with deps larger than the worker memory#8135
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files + 17 21 suites +17 10h 49m 29s ⏱️ + 9h 55m 16s Results for commit f3881d2. ± Comparison against base commit ef59142. ♻️ This comment has been updated with latest results. |
b2d4a7d to
28b1a43
Compare
28b1a43 to
f3881d2
Compare
Member
This is only true for array workloads atm |
fjetter
approved these changes
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check is somewhat cruder than what was described in the issue above.
I tried setting up a system that graciously copes with heterogeneous clusters where a few workers mount much more memory than the rest (a somewhat common design). However
sum(dts.nbytes for dts in ts.dependencies)heap memory, orSo in the end I opted for a crude order-of-magnitude check and, in the case of heterogenous clusters, explicitly expect the user to use worker or resource constraints.
Note
This catches
client.gather(client.compute(collection)), but notcollection.compute()ordask.compute(collection), as only the first one has a finalizer; the other two fetch the individual chunks directly from the original workers to the client.