Skip to content

Deprecate asynchronous Listener.stop() #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hendrikmakait merged 1 commit into from
Sep 4, 2023
Merged

Deprecate asynchronous Listener.stop() #8151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions distributed/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,8 +656,9 @@ def _stop_listeners(self) -> asyncio.Future:
if inspect.isawaitable(future):
warnings.warn(
f"{type(listener)} is using an asynchronous `stop` method. "
"Support for asynchronous `Listener.stop` will be removed in a future version",
PendingDeprecationWarning,
"Support for asynchronous `Listener.stop` has been deprecated and "
"will be removed in a future version",
DeprecationWarning,
)
listeners_to_stop.add(future)
elif hasattr(listener, "abort_handshaking_comms"):
Expand Down
2 changes: 1 addition & 1 deletion distributed/tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,7 +1402,7 @@ class TCPAsyncListenerBackend(TCPBackend):
@gen_test()
async def test_async_listener_stop(monkeypatch):
monkeypatch.setitem(backends, "tcp", TCPAsyncListenerBackend())
with pytest.warns(PendingDeprecationWarning):
with pytest.warns(DeprecationWarning):
async with Server({}) as s:
await s.listen(0)
assert s.listeners
Expand Down